-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dgw): improve network interface information extraction #1290
Conversation
Let maintainers know that an action is required on their side
|
// Linux interfaces does not come with an id | ||
pub id: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Should it be named adapter_id
or adapter_name
instead? Or is this naming used somewhere else? I think Paul linked a reference somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think id is fine, the struct named as Adapter
@irvingoujAtDevolution CI is red for Linux, can you check that? EDIT: Looks like it’s a problem with aws-lc again. Probably unrelated to your code. |
@irvingoujAtDevolution I think you can rebase on master. The problem appears to be fixed. |
Improved api/net/config end point, correctly return ip and routes for both windows and linux. Renamed struct field to better match it's semantices.
Example output
From api request
from ipconfig