chore: Improve default error handling and fix stacktrace #1379 #1409 #1432
Closed
Alexj9837 wants to merge 1 commit intoDiamondLightSource:mainfrom
Closed
chore: Improve default error handling and fix stacktrace #1379 #1409 #1432Alexj9837 wants to merge 1 commit intoDiamondLightSource:mainfrom
Alexj9837 wants to merge 1 commit intoDiamondLightSource:mainfrom
Conversation
Alexj9837
force-pushed
the
chore-_improve_default_error_handling(#1409)
branch
from
4527ef7 to
ad4e35a
Compare
Alexj9837
force-pushed
the
chore-_improve_default_error_handling(#1409)
branch
from
ad4e35a to
5e8a647
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1379
Fixes #1409
Both issues related to error handling in the REST client.
#1379 - String matching in
check_connectionbroke in #935 when theerror format changed to include the status code.
Fixed by catching 'UnauthorisedAccessError' instead of string matching, this was fixed in 1409
#1409 - Expanded the exception handler to raise different types per
status code rather than bundling everything into
BlueskyRemoteControlError.