Skip to content

Update fast shutter and selectable source device names#1939

Open
oliwenmandiamond wants to merge 3 commits intomainfrom
Update_devices_set_name
Open

Update fast shutter and selectable source device names#1939
oliwenmandiamond wants to merge 3 commits intomainfrom
Update_devices_set_name

Conversation

@oliwenmandiamond
Copy link
Contributor

Override set_name method on fast shutter and selectable source devices. This is similar to motor where you name the primary signal to be same name as the device so when reading it makes more sense

e.g for a shutter called fsj1 it now reads as

{"fsj1" : {"value": InOut.IN, ...}}

rather than

{"fsj1-shutter_value" : {"value": InOut.IN}}

Instructions to reviewer on how to test:

  1. Check tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner February 24, 2026 16:43
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (fa0d70d) to head (3ad0d59).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1939   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         314      314           
  Lines       11778    11787    +9     
=======================================
+ Hits        11667    11676    +9     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram
Copy link
Contributor

Have you discussed with @coretl about the possibility of putting this in ophyd-async? I feel like we might always want the hinted signal to behave like this?

@oliwenmandiamond
Copy link
Contributor Author

oliwenmandiamond commented Mar 6, 2026

Have you discussed with @coretl about the possibility of putting this in ophyd-async? I feel like we might always want the hinted signal to behave like this?

Yes, we have been working on bluesky/ophyd-async#1200 and should fix this issue. Devices can be StandardMovable and it takes care of all the boilerplate such the readback as device name, subscribe functions etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants