Conversation
jacob720
changed the base branch from
main
to
1504_read_beamlineParameters_through_config_server
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
==========================================
- Coverage 92.95% 92.87% -0.09%
==========================================
Files 157 155 -2
Lines 8592 8490 -102
==========================================
- Hits 7987 7885 -102
Misses 605 605
🚀 New features to boost your workflow:
|
rtuck99
reviewed
Mar 11, 2026
| """ | ||
|
|
||
| get_hyperion_config_client().refresh_cache() | ||
| get_config_client("i03").reset_cache() |
Contributor
There was a problem hiding this comment.
I don't think we should do this here, some config will already have been initialised when the blueapi context was loaded, so we might be in an inconsistent state here.
Whilst there is somewhere in baton_handler we can do this for in-process UDC, I'm not sure there is anywhere convenient yet for hyperion-blueapi
Contributor
There was a problem hiding this comment.
I have raised
jacob720
force-pushed
the
1629_remove_mx_config_client
branch
from
129ba87 to
452dd38
Compare
Base automatically changed from
1504_read_beamlineParameters_through_config_server
to
main
March 13, 2026 16:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Requires:
Removes
MXConfigClientand pushes feature settings into the config server. theMXConfigClienthad a refresh cache method, which I've added to the ConfigClient in the config server repo in the PR above. The cache is cleared whenever the baton is passed to UDC.Also updates the repo to reflect breaking file structure changes in
daq-config-serverDiamondLightSource/daq-config-server#165Instructions to reviewer on how to test:
Checks for reviewer