Skip to content

Fix tests against dodal change#1676

Merged
rtuck99 merged 1 commit intomainfrom
fix_tests_against_dodal
Mar 16, 2026
Merged

Fix tests against dodal change#1676
rtuck99 merged 1 commit intomainfrom
fix_tests_against_dodal

Conversation

@jacob720
Copy link
Contributor

Fixes our tests against DiamondLightSource/dodal#1971

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@jacob720 jacob720 requested a review from a team as a code owner March 13, 2026 17:43
@github-actions
Copy link

Please add a label to this PR. This helps with generating helpful release notes.

@jacob720 jacob720 added the dev experience Changes relating to developer experience label Mar 13, 2026
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (023dda5) to head (d3cd5c1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1676   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files         157      157           
  Lines        8592     8592           
=======================================
  Hits         7987     7987           
  Misses        605      605           
Components Coverage Δ
i24 SSX 77.32% <100.00%> (ø)
hyperion 98.60% <100.00%> (ø)
other 98.34% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rtuck99 rtuck99 merged commit 6035cd6 into main Mar 16, 2026
16 of 17 checks passed
@rtuck99 rtuck99 deleted the fix_tests_against_dodal branch March 16, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants