Allow "status" and "severity" on In record init#111
Merged
AlexanderWells-diamond merged 3 commits intomasterfrom Oct 14, 2022
Merged
Allow "status" and "severity" on In record init#111AlexanderWells-diamond merged 3 commits intomasterfrom
AlexanderWells-diamond merged 3 commits intomasterfrom
Conversation
Add new tests and refactor existing ones Add docs
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 87.64% 87.03% -0.61%
==========================================
Files 14 14
Lines 963 972 +9
==========================================
+ Hits 844 846 +2
- Misses 119 126 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Unit Test Results 15 files ± 0 15 suites ±0 29m 51s ⏱️ - 1m 5s Results for commit dc4a63f. ± Comparison against base commit 3f0ec72. This pull request removes 1 and adds 18 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Araneidae
approved these changes
Oct 14, 2022
Collaborator
Araneidae
left a comment
There was a problem hiding this comment.
Looks pretty straightforward. Probably worth making the one mentioned change.
This stops us from accidentally overriding a "STAT" value if there's also "status" defined, for example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows users to specify
severityandstatuson record initialization, with values from thesoftioc.alarmmodule.Note that "PINI" is set to "YES" by default, which means that the alarm status is immediately reset when the IOC is initialized. I'm not sure if we need to do anything fancy like disable "PINI" when we spot a
statusorseveritykeyword?Closes #57