Allow waveform.set() to be called before iocInit()#22
Conversation
|
@thomascobb , didn't realise our CI was so broken! I asked @MJGaughran to make this a pull request so that CI would give it a sanity check ... but that seems to be a bit busted 😞 |
|
Am happy with this, but will wait for CI to be fixed I guess... |
|
PR #20 contains both documentation fixes and fixes for the CI. Once that's merged this should clear up. It's also pending review at the moment. |
|
I'll make a couple of docs tweaks to #20 then merge it |
MJGaughran
force-pushed
the
fix-waveform-set
branch
from
503f4a0 to
55b3b28
Compare
With CGP-182 (944e072), waveform.set() was modified to use the dtype attribute, which is only created after softioc.iocInit() is called. This change adds a default for dtype, preventing this issue.
MJGaughran
force-pushed
the
fix-waveform-set
branch
from
55b3b28 to
f911e9c
Compare
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 82.03% 82.05% +0.02%
==========================================
Files 13 13
Lines 796 797 +1
==========================================
+ Hits 653 654 +1
Misses 143 143
Continue to review full report at Codecov.
|
|
I added a test too and merged in master |
5 participants
Fixes #21.
With CGP-182 (944e072), waveform.set() was modified to use the dtype attribute, which is only created after softioc.iocInit() is called.
This change adds a default for dtype, preventing this issue.