Changes required for integration into tickit simulation framework#28
Merged
thomascobb merged 7 commits intomasterfrom Aug 16, 2021
Merged
Changes required for integration into tickit simulation framework#28thomascobb merged 7 commits intomasterfrom
thomascobb merged 7 commits intomasterfrom
Conversation
5e7d48d to
9012b28
Compare
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 85.83% 85.81% -0.02%
==========================================
Files 13 13
Lines 812 818 +6
==========================================
+ Hits 697 702 +5
- Misses 115 116 +1
Continue to review full report at Codecov.
|
9012b28 to
df90f39
Compare
996cfb8 to
8b868eb
Compare
Contributor
Author
|
@Araneidae Mac builds (apart from python 2.7) seem to be stuck in a queue somewhere on Github Actions, but I think they will work fine, so this is ready for review |
Araneidae
reviewed
Aug 13, 2021
Collaborator
Araneidae
left a comment
There was a problem hiding this comment.
I realise I have no idea what this patch is doing, certainly no idea what "tickit" is... Not sure I can contribute very much
thomascobb
commented
Aug 13, 2021
Contributor
Author
thomascobb
left a comment
There was a problem hiding this comment.
I've commented on the lines I'd like reviewed
4069b59 to
8158b5d
Compare
thomascobb
commented
Aug 13, 2021
511cd12 to
b2cbcff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we use epicscorelibs libca in cothread
Move this as early as we can to avoid loading 2 versions of libca by mistake
Allow AsyncioDispatcher to take existing event loop
Need this if we want to embed IOC in existing asyncio app
Add ability to add arbitrary lines to Db file and test
Need this so we can read arbitrary db file, remove DTYP lines, add pythonSoftIOC records for logic of those records, then have it appear in the db file that is loaded in the IOC
See tests/sim_asyncio_ioc_override.py for an example of this