Only use the calculated length if NELM was NOT provided during record creation#38
Only use the calculated length if NELM was NOT provided during record creation#38AlexanderWells-diamond wants to merge 4 commits intomasterfrom
Conversation
There could certainly be a lot more tests written - awaiting discussion in PR to see how many more should be written.
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 85.74% 85.92% +0.17%
==========================================
Files 13 13
Lines 828 831 +3
==========================================
+ Hits 710 714 +4
+ Misses 118 117 -1
Continue to review full report at Codecov.
|
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
I haven't committed any vscode config yet as @Araneidae doesn't use vscode. However as there are now two of us doing this, maybe we should. What do you think @Araneidae ?
There was a problem hiding this comment.
Thinking about it, if we do go down that route we should probably just bring across all the .vscode settings from the template module, rather than what I've done here and just a small selection to get one particular piece working as I wanted.
|
This is now obsoleted by PR #60 |
3 participants
Closes #37
This PR is what I think the minimum fix is for the linked issue - it allows setting both
initial_valueandNELMduring waveform record creation such that both keywords are respected.It does not currently attempt to do anything regarding the "duplicate"
lengthvsNELMorvaluevsinitial_valuekeyword arguments. Using "mixed pairs" of Python and EPICS keywords will not work in all cases. Please let me know what, if anything, I should do with that.A single test is written to cover the one case I originally identified - depending on the outcome of discussion I can write more, as appropriate.