Conversation
|
This PR is parked until #63 is merged and released, then this branch will need to be rebased. |
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 85.37% 85.38%
=======================================
Files 13 13
Lines 834 814 -20
=======================================
- Hits 712 695 -17
+ Misses 122 119 -3
Continue to review full report at Codecov.
|
As we don't have Black formatter running, this at least provides some of the functionality without breaking any existing formatting.
Turns out I hadn't saved the file before previous commit...
Araneidae
force-pushed
the
remove_python2
branch
from
4cec9e1 to
878ebac
Compare
Araneidae
left a comment
Araneidae
left a comment
There was a problem hiding this comment.
Looks like we also have some Python version checks in softioc/extension.c; these can also go.
|
@Araneidae I've made all the changes requested, and CI is now passing. Please let me know if this is good to merge. It seems the previous error is a transient problem with codecov that disappeared on re-runs. |
Araneidae
left a comment
Araneidae
left a comment
There was a problem hiding this comment.
Couple more tweaks, then we're there.
|
Looks good to me. |
2 participants
This PR standardises Python 3.6 as the lowest supported version of Python, dropping support for Python 2.7.
3.6 was chosen as that's where our CI runs tests, although it wasn't declared as such in the setup.cfg until I edited it. If this should actually be Python3.7 we should also remove 3.6 from CI.
I have removed all references to 2.7, mostly by removing all Python version checking code, and done some fairly trivial refactoring where appropriate.
This also adds some auto-formatting of whitespace/newlines on save to VSCode, as we don't use an autoformatter.
Closes #61