document: Simplify temporary file handling #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of spawning subprocess, use GIO for the copy operation, and use a unique file name for the temporary file. Also, delete the temporary file when the document is closed.
Diego-Ivan
requested changes
Apr 16, 2025
Owner
Diego-Ivan
left a comment
Diego-Ivan
left a comment
There was a problem hiding this comment.
Thank you so much for checking this out! I removed the GIO uses here because of a weird bug, but I totally forgot about it later. I just tested this locally and it works perfectly. Just some minor adjustments and this would be good to go!
| if (!success) { | ||
| critical ("Processed failed"); | ||
| try { | ||
| tmp_file = GLib.File.new_tmp ("pdf-metadata-editor-XXXXXX.pdf", out stream); |
Owner
There was a problem hiding this comment.
Use GLib.File.new_tmp_async instead.
| } catch (Error e) { | ||
| throw new IOError.FAILED (@"Failed to copy file to temporary location: %s", e.message); | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
You should close the stream using stream.close_async. I'm not sure if closing it before freeing it is the default behaviour, but we better be cautious :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of spawning subprocess, use GIO for the copy operation, and use a unique file name for the temporary file. Also, delete the temporary file when the document is closed.