Add sorting of Tailwind CSS class names in RSX #4203
+1,028
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3478.
This takes the same approach as the prettier plugin, which is to load the Tailwind CSS file to parse the list of available Tailwind CSS classes, and use that along with a bit of additional sorting to determine the correct order for classes.
This implementation is somewhat limited at the moment. For example, it can only handle string literals, and it cannot handle class strings that are defined as consts outside of an
rsx!block. It is hoped that this can be improved in the future. However, this implementation should cover the majority of cases.