Conversation
JustinCCYap
reviewed
Jun 11, 2025
| # Create plot | ||
| plot.data <- pred$fit | ||
| names(plot.data) <- pred$predictor | ||
| names(plot.data) <- if (inherits(pred$predictor, "POSIXct")) strftime(pred$predictor) |
Contributor
There was a problem hiding this comment.
Should a format be specified for strftime to match what it used to do? Right now does it use the default which is "%Y-%m-%d %H:%M:%S"?
Contributor
Author
There was a problem hiding this comment.
strftime uses the correct default. I think previously it was calling as.character which used a different format, but for `strftime the default format is fine.
Contributor
There was a problem hiding this comment.
So the format will change for users?
Contributor
Author
There was a problem hiding this comment.
No. The change affects whether the plotly can correctly parse the dates. If the parsing works, plotly selects nice date defaults (which are the same as before)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
y.zeroto FALSE (this means that 0 is not forced on the y-axis) and matches behaviour of currrent spline plots