adjust for quotation marks in position of attributes - #803
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the position information for text and macro nodes within XML/HTML attribute values to exclude the surrounding quotation marks. Previously, the position data included the quotes, but now it correctly points only to the content inside the quotes.
Key Changes:
- Added an
adjustForQuotesparameter to thelezerNodeToPositionutility function that adjusts position offsets by +1 for start and -1 for end to skip quotation marks - Applied this adjustment when computing positions for attribute value children
- Added test coverage for both text nodes and macro nodes within attribute values
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/parser/src/lezer-to-dast/lezer-to-dast-utils.ts |
Added optional adjustForQuotes parameter to lezerNodeToPosition function with logic to adjust offsets to exclude surrounding quotes |
packages/parser/src/lezer-to-dast/lezer-to-dast.ts |
Applied the quote adjustment when computing position for attribute value text nodes by passing true as the third argument |
packages/parser/test/dast-advanced.test.ts |
Added two test cases verifying correct position calculation for text nodes and macros within attribute values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@siefkenj, I hope it is OK if I merge this in shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the position of attributes so that they do not include the quotation marks. Importantly, this fixes the position of macros (or references) inside attributes.
Fixes #547