refactor: use shared mapProject helper in add/update-projects #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace inline project mapping logic with centralized mapProject helper - Add comprehensive output schema validation tests - Ensure structured output strictly matches ProjectSchema (no extra API properties) - Fix module import paths in test files (add .js extension)
scottlovegrove
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR refactors
add-projectsandupdate-projectstools to use the centralizedmapProjecthelper function fromtool-helpers.js, ensuring consistent project mapping across the codebase.Changes
add-projects.tsandupdate-projects.tswith the sharedmapProjecthelperProjectSchemawith no extra API properties leaking through.jsextensions to module imports in test filesWhy
The inline mapping logic was duplicated and could drift out of sync. Using the centralized
mapProjecthelper:PR Checklist
getMcpServerAND exported insrc/index.ts- N/A, refactoring only