Skip to content

Conversation

@scottlovegrove
Copy link
Contributor

This PR basically applies my feedback from #351. Because the package has gone out containing the changes from #351, I've had to this in a deprecated manner to ensure we aren't introducing a breaking change.

@scottlovegrove scottlovegrove requested review from amix and gnapse October 14, 2025 13:32
@scottlovegrove scottlovegrove self-assigned this Oct 14, 2025
@scottlovegrove scottlovegrove merged commit ee23ba3 into main Oct 14, 2025
1 check passed
@scottlovegrove scottlovegrove deleted the scottl/activity-api-updates branch October 14, 2025 13:34
@amix
Copy link
Member

amix commented Oct 14, 2025

Thanks, @scottlovegrove 👏

2 macro comments:

  • I would recommend not implementing backward compatibility. We just introduced this yesterday, and we have an opportunity to get this right without creating debt 🤔
  • I find some of the tests too verbose. Maybe we could just for the critical things (not tirival things like date formatting)

* When false, filters for events with an initiator.
* When null or undefined, no filtering on initiator is applied.
*/
initiatorIdNull?: boolean | null
Copy link
Member

@amix amix Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What were we smoking here when initiatorIdNull was created 😱🤯

@scottlovegrove
Copy link
Contributor Author

  • I would recommend not implementing backward compatibility. We just introduced this yesterday, and we have an opportunity to get this right without creating debt 🤔

I considered doing this, but I looked on npm, and it's already been downloaded nearly 200 times. Now that could be just our own CI checks, I don't know, but it seemed a not-insignificant amount, and I didn't want to be a bad SDK maintainer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants