Open
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| - `build-scripts/process-meta.js`: Advanced processor with CLI options (`--verbose`, `--no-backup`, `--input`/`--output`), JSON schema validation (required: `id`, `name`, `version`, `description`, `links.github`, `logo`, `tags` array). | ||
|
|
||
| Exemplary blueprint: `blueprints/ghost/`—`docker-compose.yml` exposes port 2368; `template.toml` maps domain to Ghost service; meta entry tags as ["blogging", "cms"]. | ||
| Exemplary blueprint: `blueprints/ghost/`—`docker-compose.yml` uses `expose: ["2368"]` for port exposure; `template.toml` maps domain to Ghost service; meta entry tags as ["blogging", "cms"]. |
There was a problem hiding this comment.
Inaccurate exemplary blueprint description
The updated description says blueprints/ghost/docker-compose.yml uses expose: ["2368"] for port exposure, but the actual file contains no expose directive at all. Ghost's port 2368 is handled purely through the template.toml domain configuration (port = 2_368), not via an explicit expose entry in the compose file. Since this line is presented as the canonical example for AI agents to follow, an inaccurate claim here could cause generated blueprints to be structured incorrectly.
Consider updating the line to reflect what the blueprint actually does:
Suggested change
| Exemplary blueprint: `blueprints/ghost/`—`docker-compose.yml` uses `expose: ["2368"]` for port exposure; `template.toml` maps domain to Ghost service; meta entry tags as ["blogging", "cms"]. | |
| Exemplary blueprint: `blueprints/ghost/`—`docker-compose.yml` defines the service (port proxied by Dokploy via `template.toml`); `template.toml` maps domain to Ghost service on port 2368; meta entry tags as ["blogging", "cms"]. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update documentation for #730
Generated by Dosu
Greptile Summary
This PR updates
.github/copilot-instructions.mdto clarify the port-mapping policy introduced in PR #730: blueprints must useexposeinstead ofportswith host mappings, and this is now stated explicitly ("NEVER useportswith host port mappings") in three places—the key files section, the development workflow, and the conventions section.AGENTS.mdguidance (line 150: "NEVER include:ports(useexposeonly)").ports.docker-compose.yml"usesexpose: ["2368"]for port exposure", butblueprints/ghost/docker-compose.ymlcontains noexposedirective at all—Ghost's port is handled entirely viatemplate.toml's domain configuration. Since this line is labelled as the reference example for AI agents, the inaccuracy should be corrected.Confidence Score: 4/5
expose: ["2368"]when it does not) lowers the score slightly because this file serves as an AI collaboration guide and inaccurate examples can mislead generated blueprints.expose.Last reviewed commit: 92020b2
(4/5) You can add custom instructions or style guidelines for the agent here!