Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
blueprints/weblate/template.toml
Outdated
| WEBLATE_SITE_TITLE = "${WEBLATE_SITE_TITLE}" | ||
| WEBLATE_SITE_DOMAIN = "${WEBLATE_SITE_DOMAIN}" | ||
| WEBLATE_ADMIN_PASSWORD = "${password:32}" | ||
| WEBLATE_ADMIN_EMAIL = "admin@example.com" | ||
| WEBLATE_ADMIN_NAME = "${WEBLATE_ADMIN_NAME}" | ||
| WEBLATE_EMAIL_HOST = "${WEBLATE_EMAIL_HOST}" | ||
| WEBLATE_EMAIL_HOST_USER = "${WEBLATE_EMAIL_HOST_USER}" | ||
| WEBLATE_EMAIL_HOST_PASSWORD = "${WEBLATE_EMAIL_HOST_PASSWORD}" | ||
| WEBLATE_SERVER_EMAIL = "${WEBLATE_SERVER_EMAIL}" | ||
| WEBLATE_DEFAULT_FROM_EMAIL = "no-reply@example.com" | ||
| REDIS_HOST = "cache" | ||
| REDIS_PORT = "6379" | ||
| POSTGRES_PASSWORD = "${password:32}" | ||
| POSTGRES_USER = "${POSTGRES_USER}" | ||
| POSTGRES_DB = "${POSTGRES_DB}" | ||
| POSTGRES_HOST = "${POSTGRES_HOST}" |
There was a problem hiding this comment.
Self-referencing variables resolve to empty values
Several variables in the [variables] section reference themselves (e.g., WEBLATE_SITE_TITLE = "${WEBLATE_SITE_TITLE}"), which will resolve to empty strings since no actual default is provided. This affects: WEBLATE_SITE_TITLE (line 9), WEBLATE_SITE_DOMAIN (line 10), WEBLATE_ADMIN_NAME (line 13), WEBLATE_EMAIL_HOST (line 14), WEBLATE_EMAIL_HOST_USER (line 15), WEBLATE_EMAIL_HOST_PASSWORD (line 16), WEBLATE_SERVER_EMAIL (line 17), POSTGRES_USER (line 22), POSTGRES_DB (line 23), and POSTGRES_HOST (line 24).
These should have sensible literal defaults. For example, other templates (like authentik and n8n-with-postgres) define values like POSTGRES_USER = "weblate", POSTGRES_DB = "weblate", and POSTGRES_HOST = "database" (matching the docker-compose service name). WEBLATE_SITE_DOMAIN should reference "${main_domain}", and WEBLATE_SITE_TITLE should have a literal default like "Weblate". WEBLATE_ADMIN_NAME could default to "Admin". Without these defaults, the deployment will likely fail or produce a misconfigured instance.
Rule Used: AGENTS.md (source)
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
What is this PR about?
New PR of Weblate
Checklist
Before submitting this PR, please make sure that:
Greptile Summary
This PR adds a new Weblate (web-based translation tool) template with Docker Compose services for Weblate, Valkey (Redis-compatible cache), and PostgreSQL 18. The template includes good security practices like
read_onlycontainers andtmpfsmounts, proper healthchecks, and correct volume paths for PostgreSQL 18+.Key issues to address before merging:
template.toml: Multiple variables (e.g.,POSTGRES_USER,POSTGRES_DB,POSTGRES_HOST,WEBLATE_SITE_TITLE,WEBLATE_SITE_DOMAIN,WEBLATE_ADMIN_NAME) reference themselves instead of providing actual default values, which will cause them to resolve to empty strings and likely break the deployment.weblate/weblate:latestshould be pinned to a specific version (e.g.,5.11.2), andmeta.jsonversionfield should match.3.9instead of the project-standard3.8.Confidence Score: 2/5
blueprints/weblate/template.toml(self-referencing variables) andblueprints/weblate/docker-compose.yml(unpinned image tag).Last reviewed commit: 626fdca
(2/5) Greptile learns from your feedback when you react with thumbs up/down!
Context used: