Skip to content

Log rate limits as info so they can be silenced #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Log rate limits as info so they can be silenced #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion controllers/dopplersecret_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,13 @@ func (r *DopplerSecretReconciler) Reconcile(ctx context.Context, req ctrl.Reques
err = r.UpdateSecret(ctx, dopplerSecret)
r.SetSecretsSyncReadyCondition(ctx, &dopplerSecret, err)
if err != nil {
log.Error(err, "Unable to update dopplersecret")
logMsg := "Unable to update dopplersecret"
// log rate limits at info level so they can be told apart from other errors and silenced by setting log level to error
if errors.IsTooManyRequests(err) {
log.WithValues("error", err).Info(logMsg)
} else {
log.Error(err, logMsg)
}
return ctrl.Result{
RequeueAfter: requeueAfter,
}, nil
Expand Down