Skip to content

Feature/post request when url is too long #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aszydlo-ras merged 4 commits into from
Sep 11, 2025
Merged

Feature/post request when url is too long #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29da12e
switch to POST when csr URL is too long
aszydlo-ras Sep 10, 2025
01d216c
fix POST
aszydlo-ras Sep 10, 2025
caacba9
package lock
aszydlo-ras Sep 10, 2025
de42b63
fix test
aszydlo-ras Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions modules/dasBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,15 @@ function buildUserIds(customParams) {

function getNpaFromPubConsent(pubConsent) {
const params = new URLSearchParams(pubConsent);
return params.get('npa') == '1';
return params.get('npa') === '1';
}

function buildOpenRTBRequest(bidRequests, bidderRequest) {
const { customParams, keyValues } = parseParams(
bidRequests[0].params,
bidderRequest,
);
const imp = bidRequests.map((bid, index) => {
const imp = bidRequests.map((bid) => {
const sizes = getAdUnitSizes(bid);
const imp = {
id: bid.bidId,
Expand Down Expand Up @@ -270,11 +270,29 @@ export const spec = {

buildRequests: function (validBidRequests, bidderRequest) {
const data = buildOpenRTBRequest(validBidRequests, bidderRequest);
const jsonData = encodeURIComponent(JSON.stringify(data));
const jsonData = JSON.stringify(data);
const baseUrl = getEndpoint(data.ext.network);
const fullUrl = `${baseUrl}?data=${encodeURIComponent(jsonData)}`;

// Switch to POST if URL exceeds 8k characters
if (fullUrl.length > 8192) {
return {
method: 'POST',
url: baseUrl,
data: jsonData,
options: {
withCredentials: true,
crossOrigin: true,
customHeaders: {
'Content-Type': 'text/plain'
}
},
};
}

return {
method: 'GET',
url: `${getEndpoint(data.ext.network)}?data=${jsonData}`,
url: fullUrl,
options: {
withCredentials: true,
crossOrigin: true,
Expand Down
Loading
Loading