Conversation
|
Overall looks solid, not many comments from me since I'm just not familiar with this library/code. For some reason, the overall PR has no files changed. Maybe its bc you haven't yet resolved merge conflicts with main? In any case, I looked through the commits, and other than some not having files changed either, I don't see obvious issues. As long as you tested it, I trust it. Few comments: A great deal of our data is still in the Logic 1 format, and so I don't think it's a good idea to entirely deprecate it. Can we have a flag to toggle whether we're parsing Logic 1 or Logic 2 data? Could you briefly describe any testing conducted in the PR description? @Saagar-Arya do you have comments about the limitations? I'm not familiar with those files. |
…ween the two (in the new bash scripts), will test logic2 hydrophones
…hydrophone arrays
Updated
revised_scripts/to use Logic2 software instead of the original Logic1Changes
revised_scripts/logic/logic.pyto use Logic2 Software. Note that merging this will make Logic1 no longer workrevised_scripts/Controller.pyandrevised_scripts/recorder.pyto match with the new Logic2 scriptsrevised_scripts/hydrophones/hydrophone_array.pyto use the new data format which the Logic2 scripts saves the binary files asLimitations
First, csv files will no longer work as previously. Using data collection current only works with binary files. Also,
parser.pymay no longer work with the new format in which the data is saved from Logic2.