Update OmegaV1GoverningEqns.md#324
Conversation
I found that this change would require many updates in both Omega and Polaris. I don’t think it’s necessary at this point, so we should keep using |
mark-petersen
left a comment
There was a problem hiding this comment.
@hyungyukang thanks for your attention to the documentation. This looks good to me.
- Update definition of unit normal since the current definition is actually upward normal
|
@hyungyukang, I also noticed several issues with this document. Most are different from your changes but I think a few may overlap. After we merge your fixes, I would like to rebase #326 and have you take a look at that. |
- Remove \rho_0 in (64) and add \tilde to (63)
I would be strongly in favor or renaming |
This PR slightly modifies the Omega-V1 governing equation document OmegaV1GoverningEqns.md.
Variable Definitionsto match its usage in the documentCompiled version is here.
The code needs to be updated (e.g., changing
LayerThicknesstoPseudoThickness) to match the document. I will open another PR for this.Checklist