Adds new global reductions#330
Open
philipwjones wants to merge 3 commits intoE3SM-Project:developfrom
Open
Conversation
- fixes treatment of index range - includes reproducible sums for device arrays - adds minval and maxval routines - results are return values rather than function parameters - adds a more robust unit test for all interfaces - updates documentation - all routines abort on error rather than returning an error code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rewrite of all the global reductions routines to fix the treatment of restricted address ranges. It includes
This PR does not include multi-field interfaces, except for scalars. Those will be added in a future PR. Also, the reproducible sums for device R8 arrays are actually computed on the host currently - custom kokkos reductions to compute on the device will also be added later. The additional cost of computing on host is negligible compared to MPI overhead.
Fixes #320
Testing:
New unit test driver added for Reduction unit tests and updated to run on 8 MPI ranks
All CTest unit tests pass on Chrysalis (Intel), Frontier CPU and GPU with gnu, amd.
Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build