Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new hierarchical-parallel helper to search an inner index range in parallel, intended to support upcoming physics (e.g., submesoscale eddy parameterization) by enabling “find first match” behavior inside team-level kernels.
Changes:
- Added
parallelSearchInnerto the Kokkos hierarchical-parallel wrappers (returns first index matching a predicate, or-1). - Added a unit test covering full-range and sub-range search behavior.
- Updated the developer guide to document the new inner-loop pattern.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| components/omega/src/infra/OmegaKokkos.h | Implements parallelSearchInner with host/device-specific behavior. |
| components/omega/test/infra/OmegaKokkosHiParTest.cpp | Adds coverage validating correctness of the new search primitive. |
| components/omega/doc/devGuide/ParallelLoops.md | Documents parallelSearchInner and provides an example usage snippet. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
14ddbb1 to
f26197e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f26197e to
87659ae
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
87659ae to
3045ab0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds a function for searching an index range in parallel at the inner level of hierarchical parallelism. It is going to be useful in implementing the submesoscale eddy parametrization.
Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build