Obsolete environmental exposure measurement terms (issue #2737) - #2738
Draft
jamesamcl wants to merge 1 commit into
Draft
Obsolete environmental exposure measurement terms (issue #2737)#2738jamesamcl wants to merge 1 commit into
jamesamcl wants to merge 1 commit into
Conversation
…(refs #2737) Deprecate the "environmental exposure measurement" branch (EFO_0008360) in favour of ECTO exposure classes, completing the linkage begun in #2380. - Obsoleted 18 terms, each with obo:IAO_0100001 -> the corresponding ECTO exposure class (obsoleted_in_version 3.92, reason_for_obsolescence, owl:deprecated=true; all logical axioms removed). - Kept the 7 terms that have no ECTO equivalent (in utero, noise, sun, vitamin/nutritional/mastiha supplement, time spent outdoors) and re-parented the 4 former direct children of the root under measurement (EFO_0001444). - Imported 2 new ECTO terms: ECTO_8000000 (exposure to environmental process) and ECTO_7000068 (exposure to particulate matter). Verified: make normalize_src clean; robot reason (ELK) reports no unsatisfiable classes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jki5T73Qgyb2VGMuWsWtZy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the EFO→ECTO migration begun in #2380. The EFO-native "environmental exposure measurement" branch (
EFO_0008360, 25 terms) is deprecated in favour of ECTO (Environmental Conditions, Treatments and Exposures Ontology) exposure classes. 18 terms had a verified ECTO equivalent and are obsoleted withobo:IAO_0100001(term replaced by) → the ECTO class; 7 terms have no ECTO equivalent and are kept (re-parented undermeasurement). Closes #2737.Obsoleted + replaced (18)
Each term gets:
obsolete_label ·owl:deprecated=true·efo:obsoleted_in_version 3.92·efo:reason_for_obsolescence(refs #2737) ·obo:IAO_0100001→ ECTO class · all logical axioms removed.Mappings to double-check (best available in ECTO, flagged for reviewer):
EFO_0008361environmental tobacco smoke (passive / second-hand) →ECTO_6000029exposure to tobacco smoking (active-smoking sense) — only ECTO option, semantically broader.EFO_0006924household +EFO_0007908traffic air pollution → both collapse to the genericECTO_8000036exposure to air pollution (no household- or traffic-specific ECTO class exists).EFO_0008360root →ECTO_8000000exposure to environmental process (ECTO's top-level environmental-exposure grouping).Kept — no ECTO equivalent (7)
Not obsoleted. The 4 former direct children of the (obsoleted) root are re-parented to measurement (
EFO_0001444); the other 3 stay under their kept intermediate parents.Terms that need creating in ECTO
These 7 have no ECTO class today. To eventually migrate them too, ECTO would need new exposure to … classes (new-term requests). Suggested labels + fit notes:
LFID:0000230"exposure to noise pollution"LFID:0000226; broader than the existing ECTO "exposure to ultraviolet radiation"maternal), not as a standalone classImports
Added
ECTO_8000000andECTO_7000068tosrc/ontology/iri_dependencies/ecto_terms.txtand regeneratedsrc/ontology/imports/ecto_import.owl(via efo-importer). No hand-editing of generated import files — ECTO's own class / definition / hierarchy axioms come straight from the ECTO release.Verification
make normalize_srcclean;robot reason(ELK) → no unsatisfiable classes. (Run locally with a temporary empty stub for the gitignored, not-yet-generatedimports/mondo_import.owl; CI runs the full import pipeline.)Open question
The 7 "no ECTO equivalent" terms are kept (re-parented) rather than obsoleted-without-replacement, to avoid orphaning their existing GWAS annotations. If the branch should instead be fully retired, they can be obsoleted too (with no replacement).
Closes #2737
🤖 Generated with Claude Code
https://claude.ai/code/session_01Jki5T73Qgyb2VGMuWsWtZy