EVA-1902 - Spring Boot 2 upgrade#137
Merged
andresfsilva merged 1 commit intoEBIvariation:masterfrom May 29, 2020
Merged
Conversation
Contributor
sundarvenkata-EBI
commented
May 20, 2020
sundarvenkata-EBI
commented
- Replace Fongo with real MongoDB tests because Fongo is not supported in Spring Boot 2.1 - see here
- Update Travis and Gitlab scripts to include Mongo installations
- Update POMs to support "|" delimiters so that EVA mongo host for tests can be parametrized for both Travis and Gitlab
- javax.validation API dependency need no longer be explicitly pulled in since Spring Boot 2 contains it
- Upgrade jackson-databind version to 2.9.7 to work with Spring Boot 2
- JPA repository query methods should be marked with "Query" annotation
PR notes Use pipe delimiter in application properties so that they can be parametrized for both Travis and Gitlab Replace Fongo with real MongoDB tests because Fongo is not supported in Spring Boot 2.1 - see [here](fakemongo/fongo#357) Update Travis and Gitlab scripts to include Mongo installations Update POMs to support "|" delimiters so that EVA mongo host for tests can be parametrized for both Travis and Gitlab javax.validation API dependency need no longer be explicitly pulled in since Spring Boot 2 contains it Upgrade jackson-databind version to 2.9.7 to work with Spring Boot 2 JPA repository query methods should be marked with "Query" annotation
jmmut
approved these changes
May 21, 2020
andresfsilva
approved these changes
May 29, 2020
This was referenced May 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.