use zarr-cm for defining zarr conventions metadata#131
Merged
d-v-b merged 3 commits intoEOPF-Explorer:mainfrom Mar 20, 2026
Merged
use zarr-cm for defining zarr conventions metadata#131d-v-b merged 3 commits intoEOPF-Explorer:mainfrom
d-v-b merged 3 commits intoEOPF-Explorer:mainfrom
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
d-v-b
commented
Mar 11, 2026
| "name": "spatial:", | ||
| "schema_url": "https://raw.githubusercontent.com/zarr-conventions/spatial/refs/tags/v1/schema.json", | ||
| "spec_url": "https://github.com/zarr-conventions/spatial/blob/v1/README.md", | ||
| "description": "Spatial coordinate and transformation information" |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
this achieves a solid reduction in code, so I think this is good to go when the tests pass. |
emmanuelmathot
approved these changes
Mar 18, 2026
Contributor
emmanuelmathot
left a comment
emmanuelmathot
left a comment
There was a problem hiding this comment.
Great! I love the consolidation here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces our definitions of zarr conventions metadata stuff like uuids, etc with imports from https://github.com/zarr-conventions/zarr-cm