Added data types in abstractZono class #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is designed to address #31 but is potentially applicable to many more issues.
I believe the assumption is that in all abstractZono derived functions is that the data types are specified as doubles (or integers)
It is also possible to include the sizes (e.g., (1,1) for scaler, (:,1) for vector, etc.) or non-sparse (i.e., {mustBeNonsparse}) which is required for calling gurobi or optimvar creation.
Note: this does further limit the ability for the base zonoLAB objects to store double data within it's operations but the last discussion was with the potential of creating alternative optimZono or symZono versions instead of complete integration