Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_neon SystemTest #2345

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Feb 1, 2024

Description of changes

Adds RUNNEON SystemTest, which is designed to replicate a simple ./run_neon call in a way that can be added to aux_clm.

Not yet working!

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #): None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any:
Testing with

./run_sys_tests -t RUNNEON_Ld1.CLM_USRDAT.HIST_DATM%1PT_CLM51%BGC_SICE_SOCN_SROF_SGLC_SWAV_SESP.derecho_intel.clm-default --skip-compare --skip-generate

fails in the SHAREDLIB_BUILD phase. See /glade/derecho/scratch/samrabin/tests_0201-142855de/RUNNEON_Ld1.CLM_USRDAT.HIST_DATM%1PT_CLM51%BGC_SICE_SOCN_SROF_SGLC_SWAV_SESP.derecho_intel.clm-default.0201-142855de/ABBY/bld/cesm.bldlog.240201-143035 for example log file.

Remaining tasks:

  • Get build_phase() to work
  • Ensure run_phase() works
  • Rework run_phase() to not submit a separate job, but rather to run in the existing job
  • Add code to handle generating/comparing baselines

@samsrabin samsrabin added support user or developer needs help testing additions or changes to tests labels Feb 1, 2024
@samsrabin samsrabin self-assigned this Feb 1, 2024
@samsrabin
Copy link
Collaborator Author

@wwieder: Here's my initial stab at a SystemTest that exercises run_neon.

@ekluzek: I can't figure out why the build is failing…

"""
Builds the case
"""
if not model_only:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried with if sharedlib_only, if model_only, etc., as well as with no conditional here. I get the same build error no matter what.

@samsrabin samsrabin marked this pull request as draft February 1, 2024 22:08
@samsrabin
Copy link
Collaborator Author

Oddly, the build seems to work on Izumi but not Derecho. (It then fails in SUBMIT with Build complete is not True, but that's not entirely unexpected.)

@samsrabin samsrabin added priority: low Background task that doesn't need to be done right away. and removed support user or developer needs help labels Feb 6, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Apr 1, 2024

With #2438 and the other issues this comes back to being something that would be good to bring in if we can figure it out...

@samsrabin
Copy link
Collaborator Author

@ekluzek Did you mean #2438?

@ekluzek
Copy link
Collaborator

ekluzek commented Apr 2, 2024

Yep! Thanks for the correction @samsrabin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Background task that doesn't need to be done right away. testing additions or changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants