Merged
Conversation
2 tasks
ekluzek
approved these changes
Jun 20, 2025
Collaborator
ekluzek
left a comment
There was a problem hiding this comment.
@samsrabin and I went over this. And this is great work and I'm glad to see it come in. It fixes problems, but also makes the code more robust, with better error handling, AND it adds good testing for all this. So this will save the project time downstream.
I added a few comments/questions here that @samsrabin will decide on. I'm happy to approve it and have it come in shortly.
722504e to
63d61f4
Compare
samsrabin
commented
Jun 20, 2025
samsrabin
commented
Jun 20, 2025
- Replace NAT_PFT=15 with MAX_NAT_PFT=14 - Replace NUM_PFT=17 with MAX_PFT_GENERICCROPS=16 - Rename MAX_PFT to MAX_PFT_MANAGEDCROPS
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
--lon-type 180insubset_datacommand to avoid ambiguity.--overwriteoption.--plumber2-sites-csvoption to specify CSV file path.subset_datafailure.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed: Resolves #3262
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: As of c325805:
761bb47) aren't affected.clm_pymodssuite:/glade/derecho/scratch/samrabin/tests_0620-185305de/