ctsm5.4.023: Replace more netCDFs with NaN issues#3809
Open
samsrabin wants to merge 7 commits intoESCOMP:masterfrom
Open
ctsm5.4.023: Replace more netCDFs with NaN issues#3809samsrabin wants to merge 7 commits intoESCOMP:masterfrom
samsrabin wants to merge 7 commits intoESCOMP:masterfrom
Conversation
…temisdata/dst_source1x1tuned-cam4-forCLM_cdf5_c240202.nc'.
New file '$CESMDATAROOT/cseg/inputdata/lnd/clm2/dustemisdata/dst_source1x1tuned-cam4-forCLM_cdf5_c240202.no_nan_fill.nc'.
New fill values:
-999.0: mask
Path updated in:
bld/namelist_files/namelist_defaults_ctsm.xml
…edata/fire_emission_factors_78PFTs_c20240624.nc'.
New file '$CESMDATAROOT/cseg/inputdata/lnd/clm2/firedata/fire_emission_factors_78PFTs_c20240624.no_nan_fill.nc'.
New fill values:
Deleted fill: Comp_MW
Path updated in:
bld/namelist_files/namelist_defaults_fire_emis.xml
…fdata_esmf/PLUMBER2/ctsm5.4.0/surfdata_1x1_PLUMBER2_*.nc.
Replaced NaN or missing fill values with:
Deleted unused fill from 79 variables
Path updated in:
cime_config/usermods_dirs/clm/PLUMBER2/defaults/user_nl_clm
samsrabin
added
priority: high
samsrabin
force-pushed
the
replace-more-netcdfs-with-ifx-issues
branch
from
689d4cf to
c69d92e
Compare
Member
Author
|
The following are still failing (see #3788 and #3789): |
And delete tmp test suite.
samsrabin
changed the title
samsrabin
changed the title
ekluzek
approved these changes
Mar 9, 2026
Collaborator
ekluzek
left a comment
ekluzek
left a comment
There was a problem hiding this comment.
This is straightforward NaN changes again. So all makes sense.
It does mean we need to think about how the model writes out restart files for fields that have NaN's on it. That's something that will come later.
And run_tower for NEON and PLUMBER will need to change for FillValues as well.
I'll make issues on both of those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Replaces our remaining input netCDF files that had NaNs.
Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed: Marking this as fixing the two overarching issues, even though there are still some failing tests (see #3788 and #3789).
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? Various default input files updated to versions without NaNs.
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
tmpsuite (things marked as still failing atctsm5.3.022): Some still failing; see below. (/glade/derecho/scratch/samrabin/tests_0309-104103de/)/glade/derecho/scratch/samrabin/tests_0309-141321de/, Izumi/scratch/cluster/samrabin/tests_0309-141321iz/Remaining work
tmpsuite/glade/derecho/scratch/samrabin/tests_0309-104103de/RXCROPMATURITY_Lm61.f09_t232.IHistClm60BgcCropCrujra.derecho_intel.clm-cropMonthOutput.G.0309-104103de_int