Open
Conversation
mnlevy1981
approved these changes
Mar 12, 2024
Collaborator
mnlevy1981
left a comment
mnlevy1981
left a comment
There was a problem hiding this comment.
This all looks great, but I'm a little confused about why it works... I did the following:
$ git clone -b remove_manage_externals https://github.com/jedwards4b/POP2-CESM.git POP_rme
$ cd POP_rme/
$ git submodule update --init
$ cd externals/MARBL/
$ git log --decorate | head -n 1
commit 75827e20f40b29a30361aff4eae9801f1036a916 (HEAD, tag: marbl0.43.0)So it clearly checked out marbl0.43.0, which is the branch of MARBL we want POP to use, but the head of the default branch is 6b2a5e4 (marbl0.39.1). The only reference to a commit I see in .gitmodules is fxtag, which presumably requires fleximod to parse... so how did git know what commit to checkout?
Collaborator
|
ugh, it looks like I actually tested the branch from #80 (had both tabs open); let me close that PR in favor of this one and try again. |
Closed
Collaborator
|
Okay, I removed the From the last line, you can see it's still checking out the correct MARBL tag (and I'm still curious about how it knows) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change removes the manage_externals utility and replaces it with git-fleximod. None of the extended features of git-fleximod are used here so one can just use git-submodule instead. This allows POP to be used as part of the upcoming cesm2_3_beta18 tag which removes the manage_externals utility in cesm and moves to git-fleximod.
Testing:
Test case/suite:
Test status: bit for bit
Fixes [POP2 Github issue #]
User interface (namelist or namelist defaults) changes?