Open
Conversation
Fix longitude checks for CORDEX
…test if longitude crosses both, zero- and anti-meridian.
…and CMIP7-style format.
- Add option "verification_against_tables" to choose between verification against esgvoc and CV-tables - Until esgvoc is fully supported by the CORDEX-CMIP6 checker, verification_against_tables=True is the default - Adjusting several CORDEX-CMIP6 checks to skip the parts of the checks that require CV tables - check_attributes_match_filename: Added CORDEX-CMIP6 filename pattern and reworked project identification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to CORDEX-CMIP6 checker
check_lon_value_rangecheck into develop branchlonvalues cross zero- and anti-meridianUpdates with regards to CMIP6/7 checker:
wcrp_cmip7) will decide which DRS filename pattern is used. I am not sure if thefilename_template_keysparameter is still necessary or what it can be used for.@Ayoubnac1 This could be merged for the next release. I will be working on the esgvoc checks that shall replace the CV checks asap, but this will be part of another PR.