Conversation
jedwards4b
left a comment
There was a problem hiding this comment.
I suggest removing the three unused routines:
get_entries
get_entry_info
get_rpointer_contents.
CIME/XML/env_archive.py
Outdated
|
|
||
| yield file, content | ||
|
|
||
| # TODO check if used otherwise remove |
There was a problem hiding this comment.
I could not find any usage of any of get_entries, get_entry_info or get_rpointer_contents in CESM.
There was a problem hiding this comment.
I could not find any usage either, I'll go ahead and remove them.
|
Regarding the test failures I found that a check of the object 'archive' at line 200 of case_st_archive.py |
jedwards4b
left a comment
There was a problem hiding this comment.
Running case.st_archive --test-all reveals a problem with your new code. The
archive variable is of type Archive and not env_archive as you expect.
|
@jedwards4b Thanks, I see the issue. I'll adjust the code and have you review again. |
3b68775 to
7de43bc
Compare
Description
When using the
--copy-onlyor--last_dateoption, the latest rpointer files would be moved from the run directory breaking the ability to restart a run. The first archived rpointer file would be incorrect as CIME would move the current rpointer into the archive directory and then create all subsequent rpointer files (these would be correct).Checklist