Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dask to avoid 2024.8.0 - problems with masked fill/missing values #2504

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Aug 7, 2024

Description

Closes #2503

I will also open an issue at Dask with an MRC, but this is all we can do, for now, at our end

So far, this is an iris issue reported here SciTools/iris#6109


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (9636505) to head (8439463).
Report is 45 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2504   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         249      249           
  Lines       14123    14123           
=======================================
  Hits        13376    13376           
  Misses        747      747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi
Copy link
Contributor Author

gents @bouweandela @schlunma shall we merge this until the good folk at iris figure out how to fix the issue? 🍺

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks V! 🍻

@bouweandela bouweandela merged commit 4c21ca6 into main Aug 12, 2024
5 of 6 checks passed
@bouweandela bouweandela deleted the pin_dask branch August 12, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multimodel tests failing due to mishandling of fill/missing values
2 participants