CMORizer for ESACCI-SEAICE #3821
Conversation
|
I am looking at it now |
There was a problem hiding this comment.
@axel-lauer: Thanks for the well working cmorizer!
I tried the downloader, formatter and the check-obs recipe. All works fine. Data looks good. All files that need to be updated are modified/created.
Good to be merged from my side if you fix the little mistake that I commented on in one of the files.
Great work! 🍾
Hey @rbeucher: I finished the scientific review. Would be great if you could do the technical review for this! Thanks! |
Thanks for reviewing! The typo has been fixed here 524a186 |
There was a problem hiding this comment.
Thanks @axel-lauer for the CMORiser and @hb326, for the scientific review!
I used the downloader and formatter for the entire dataset—it works well, but I think the code could be significantly simplified.
It might also be useful to add an option to select a single region at a time.
esmvaltool/cmorizers/data/downloaders/datasets/esacci_seaice.py
Outdated
Show resolved
Hide resolved
| var['file'].format(year=loop_date.year, region=region) | ||
| ) | ||
| in_files = glob.glob(filepattern) | ||
| if not in_files: |
There was a problem hiding this comment.
This would work even if only one file is available for the year... I believe it could be improved with a more thorough validation.
There was a problem hiding this comment.
Yes, and this is intended to be able to e.g. also process incomplete years.
There was a problem hiding this comment.
I think it's good to go. Thanks for making the changes @axel-lauer
Description
This PR adds downloading and formatting scripts for the ESACCI-SEAICE dataset version L4-SICONC-RE-SSMI-12.5kmEASE2-fv3.0. The scripts process daily and monthly mean sea ice concentration (siconc).
Checklist
New or updated data reformatting script