-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ESACCI-OZONE CMORizer(formatter and downloader) for REF #3899
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Diego!
I have a couple of comments on the code. In addition, please also call the function fix_coords
(if possible) on the data to make sure that all coordinate metadata is set properly.
esmvaltool/cmorizers/data/formatters/datasets/esacci_ozone_old.ncl
Outdated
Show resolved
Hide resolved
Thanks @schlunma and @axel-lauer for your reviews. I confirm that I have addresed all the comments related to the cmorizer. Please check if the cmorized output files are fine now as the coordinates metadata look better now indeed, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Diego for addressing my comments!
Just minor ones remaining. Please make sure to add the appropriate download instructions and source (I am sure @axel-lauer will point you to the right location).
I haven't tested this though.
… config file to switch to OBS6, add check_obs entries for O3 and toz in OBS6
Following clarification with @schlunma, I had to switch to OBS6 project as by running the check_obs on the latest output files the checks were failing because during the CMORization I was using the project OBS that is referring to the CMIP5 tables and not to the CMIP6 ones. Furthermore I had also to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good now. Will approve once the documentation is updated properly. Please also update the datasets.yml
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! Didn't run the code nor looked at the output from a scientific point of view, though.
Also the link to the data does not work for me: https://cds.climate.copernicus.eu/datasets/satellite-ozone-v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few first comments:
- I think the unit conversion needs some changes (see code suggestions).
- The default time range in
cmorization
is 1984/1/1 to 2023/12/31. This needs to be changed depending on the dataset that is processed (formatter does not run otherwise):- GTO-ECV covers the period 1995/7 to 2023/04
- SAGE-CCI-OMPS covers the period 1984/10 to 2022/12
- The old downloader is still the one for the old dataset (used with the NCL formatter). As a minimum, the downloader needs to be removed but I would prefer to add a downloader to retrieve the current data from the CDS. Examples for retrieving data from CDS are, e.g. cds_satellite_soil_moisture.py or cds_xch4.py. I believe they can be used as a template with some small modifications, see CDS changing infrastructure: changes to users and possibly some cmorizers #3750. Maybe @bettina-gier can advice what is needed to download data from the (new) CDS.
Thank you for your review @axel-lauer. |
Regarding CDS
|
Description
This PR updates the
ESACCI-OZONE
cmorizer (NCL version to python) for REF, and it will produce 2 aggregated output files fortoz
(1995-2023) ando3
(1984-2022) variables defined in the CMOR Table AERmon.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
New or updated data reformatting script
To help with the number of pull requests: