Process JSON Command - Refactor JSON path handling and root support - #3455
Merged
Conversation
@Mimigris found some missing usecases for Process JSON command. One of them related to missing access to the root of a JSON, for things like `GetKeys("/")` This PR Introduces a helper to handle JSON path resolution, including root path ('/'), and refactors all relevant functions to use it. Improves consistency, reduces code duplication, and adds explicit handling for root object operations in GetValue, SetValue, RemoveValue, Contains, and related methods.
jetrotal
force-pushed
the
ProcessJSON-Fixes
branch
from
July 26, 2025 15:53
b5325d5 to
94e2a98
Compare
Member
|
Thanks for adding this, also noticed this "/" limitation (and I really wonder why "/" is not a valid JSON Path -_-). |
Ghabry
approved these changes
Jul 29, 2025
ghost
approved these changes
Jul 31, 2025
sevenc-nanashi
pushed a commit
to sevenc-nanashi/easyrpg-player
that referenced
this pull request
May 31, 2026
…Fixes Process JSON Command - Refactor JSON path handling and root support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Mimigris found some missing usecases for Process JSON command. One of them related to missing access to the root of a JSON, for things like
GetKeys("/")This PR Introduces a helper to handle JSON path resolution, including root path ('/'), and refactors all relevant functions to use it. Improves consistency, reduces code duplication, and adds explicit handling for root object operations in GetValue, SetValue, RemoveValue, Contains, and related methods.