Keep current picture sprite shown while the new one is loading - #3457
Merged
Conversation
Prevents flickering on multi-picture sequences loaded from a slow source such as a remote server. Some examples (Yume 2kki 0.127i): - entry animation in MAP0259 (Square-Square World) -> MAP3117 (Goldfish Pond) - entry animation in MAP2997 (Photographic Field) -> MAP2998 (Dining Table) - background animation in MAP3116 (Rural Starflower Field: Entrance)
ghost
requested a review
from Ghabry
July 31, 2025 14:07
ghost
added
Performance
carstene1ns
approved these changes
Oct 8, 2025
ghost
approved these changes
Oct 8, 2025
Member
|
Yeah this will only affect the web player because its the only one doing this "async" loading. Not sure which approach is looking better (unload and flicker or keep old) so will merge this and wait for feedback xD |
sevenc-nanashi
pushed a commit
to sevenc-nanashi/easyrpg-player
that referenced
this pull request
May 31, 2026
Keep current picture sprite shown while the new one is loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents flickering on multi-picture sequences loaded from a slow source such as a remote server.
Some examples (Yume 2kki 0.127i):
I've only managed to reproduce the flickering on emscripten.
Sprite hiding appears to have been introduced in 87cad88 (in order to avoid showing stale data from erased pictures?), but 32e9ad4 made unused pictures unload their sprites so I'm not sure why this condition has been kept.