ATB: Use correct default depending on the engine #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This information is currently not preserved
…determie the real default.
…o both LSD save and load Is used to determine the correct default for the AtbMode depending on the engine version (2k3e or not) To ensure that the chunk is not always written conditionally set it to -1 when it is the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 2k3e the default ATB mode is Wait instead of Active. Somehow this was missed for 8 years xD.
Unfortunately liblcf has no way to determine if a chunk was read from the file so instead I use a sentinel value (-1) and when it stays -1 it means the chunk was not read and I apply the default depending in the engine.
This doesn't have often but this API change is not breaking the Player build.