Iss 68 implement GETDEL command #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kelvinmwinuka I have not been able to reproduce this failure locally, but from what I can tell it's not related to GETDEL. 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #68
adds getdel command
adds GetDel method to generic api
Redis GETDEL says it will delete the key only if it is a string... I was unsure of the reasoning behind this, so currently my implementation deletes the key after returning its value regardless of data type (assuming the key exists). I can see use cases for wanting a more atomic "delete after get" option for keys that aren't necessarily string values. Happy to update my PR if needed.
Also added a break to the loop in randomKey method so that every call would not iterate over the entire map every time which would lead to not so random results. 🙃