Skip to content

Feature/add ci pipelines #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: Release-0.0.7
Choose a base branch
from

Conversation

evansmj
Copy link
Contributor

@evansmj evansmj commented Mar 11, 2025

Add ci pipelines

Add test workflow to Artifact, Pull Request, and Build and publish workflows.
Refactor build steps into build.yml

@evansmj evansmj force-pushed the feature/add-ci-pipelines branch from e34a7be to 7045b8c Compare March 11, 2025 01:47
@evansmj evansmj mentioned this pull request Mar 11, 2025
@evansmj
Copy link
Contributor Author

evansmj commented Mar 11, 2025

hey @ShahanaFarooqui I took a pass at fixing some failing tests due to the recent ConnectWallet updates in this pr, since it will need the new checks to pass.

The only change to ConnectWallet is I updated the REST case to use DEVICE_DOMAIN_NAME instead of HIDDEN_SERVICE_URL since that should be for the Tor case.

Can you double check the urls? I see http:// inside of some like ln-message://http://oqaer4kd7ufryngx6dsztovs4pnlmaouwmtkofjsd2m7pkq8wd.onion:5001?rune=mRXhnFyVWrRQChA9eJ01RQT9W502daqrP0JA4BiHHw89MCZGb3IgQXBwbGljYXRpb24j&invoiceRune=aHFhnFyVWrRQChA9eJ01RQT9W502daqrP0JA4BiHHw89MCZGb3IgQXBwbGljYXRpb2== and i'm not sure if that is supposed to be there.

I am not sure on the Client Key, Client Cert, and CA Cert field behavior, I updated the tests to match the behavior I see.

thanks

@ShahanaFarooqui
Copy link
Collaborator

ShahanaFarooqui commented Mar 11, 2025

@evansmj Thanks for bringing it to my attention. I merged your connect wallet test fixes with fixed https:// suffix in PR #88. Please rebase this PR on Release-0.0.7 again.

Client Key, Client Cert, and CA Cert field behavior was as expected.

Add test workflow to Artifact, Pull Request, and Build and publish workflows.
Refactor build steps into build.yml
@evansmj evansmj force-pushed the feature/add-ci-pipelines branch 2 times, most recently from f76b511 to 4ebb932 Compare March 11, 2025 13:04
@evansmj
Copy link
Contributor Author

evansmj commented Mar 11, 2025

hi @ShahanaFarooqui, what do you think of us enabling github's dependabot? I had in mind to add dependency vulnerability scanning in the pipelines, but github can manage it easier than in a pipeline from scratch.

It can alert us to vulnerabilities in our dependencies and as a separate option it can make draft pull requests with version updates for them. It uses the OWASP db which I had in mind, plus some others.

it would mean just enabling these two settings, which I don't have access to since im not a maintainer:

Screenshot 2025-03-11 at 1 35 28 PM

@ShahanaFarooqui
Copy link
Collaborator

it would mean just enabling these two settings, which I don't have access to since im not a maintainer:

We already have it enabled, but it may not be functioning as expected due to potential conflicts with organisational settings (ElementsProject).

Screenshot from 2025-03-11 10-48-37

@evansmj
Copy link
Contributor Author

evansmj commented Mar 12, 2025

it would mean just enabling these two settings, which I don't have access to since im not a maintainer:

We already have it enabled, but it may not be functioning as expected due to potential conflicts with organisational settings (ElementsProject).

Oh ok, ill bring it up at the next cln call. this pr is ready then if it looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants