-
Notifications
You must be signed in to change notification settings - Fork 13
Feature/add ci pipelines #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Release-0.0.7
Are you sure you want to change the base?
Feature/add ci pipelines #86
Conversation
e34a7be
to
7045b8c
Compare
hey @ShahanaFarooqui I took a pass at fixing some failing tests due to the recent ConnectWallet updates in this pr, since it will need the new checks to pass. The only change to ConnectWallet is I updated the REST case to use DEVICE_DOMAIN_NAME instead of HIDDEN_SERVICE_URL since that should be for the Tor case. Can you double check the urls? I see http:// inside of some like I am not sure on the Client Key, Client Cert, and CA Cert field behavior, I updated the tests to match the behavior I see. thanks |
Add test workflow to Artifact, Pull Request, and Build and publish workflows. Refactor build steps into build.yml
f76b511
to
4ebb932
Compare
hi @ShahanaFarooqui, what do you think of us enabling github's dependabot? I had in mind to add dependency vulnerability scanning in the pipelines, but github can manage it easier than in a pipeline from scratch. It can alert us to vulnerabilities in our dependencies and as a separate option it can make draft pull requests with version updates for them. It uses the OWASP db which I had in mind, plus some others. it would mean just enabling these two settings, which I don't have access to since im not a maintainer: ![]() |
Oh ok, ill bring it up at the next cln call. this pr is ready then if it looks fine |
Add ci pipelines
Add test workflow to Artifact, Pull Request, and Build and publish workflows.
Refactor build steps into build.yml