Remove deprecations for 25.09 #8352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/remove-deprecations-25.09
branch
2 times, most recently
from
e56e905 to
dcea8e8
Compare
Changelog-Removed: Config: `max-locktime-blocks` (deprecated v24.05, disabled v25.02). Signed-off-by: Rusty Russell <[email protected]>
Changelog-Removed: Config: autodetection for rest-port/rest-protocol/rest-host/rest-certs options to clnrest-* (deprecated v23.11, disabled v25.02). Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: JSON-RPC: `commando-rune`, `commando-listrunes`, `commando-blacklist` (deprecated v23.08, disabled v25.05).
Changelog-Removed: Config: `experimental-anchors` and `experimental-onion-messages` (deprecated 24.02 / 24.08, disabled v25.05). Signed-off-by: Rusty Russell <[email protected]>
ShahanaFarooqui
force-pushed
the
guilt/remove-deprecations-25.09
branch
from
dcea8e8 to
42cb85b
Compare
ShahanaFarooqui
requested changes
Jun 13, 2025
Comment on lines
-15
to
-17
| | commando-rune | Command | v23.08 | v25.02 | replaced with `lightning-createrune` | | ||
| | commando-listrunes | Command | v23.08 | v25.02 | replaced with `lightning-showrunes` | | ||
| | commando-blacklist | Command | v23.08 | v25.02 | replaced with `lightning-blacklistrune` | |
There was a problem hiding this comment.
We should also remove the documentation related to the deprecated command types since they are being removed from the codebase. It will keep our documentation in sync with the codebase and remove references to functionality that is being removed.
I do not have a push permission for the PR but the changes should include:
-
Deleting the rpc schema files:
- ./doc/schemas/commando-rune.json
- ./doc/schemas/commando-listrunes.json
- ./doc/schemas/commando-blacklist.json
-
Updating the doc/Makefile to remove references to these commands:
diff --git a/doc/Makefile b/doc/Makefile
@@ -34,10 +34,7 @@ MARKDOWNPAGES := doc/addgossip.7 \
doc/checkmessage.7 \
doc/checkrune.7 \
doc/close.7 \
- doc/commando-blacklist.7 \
doc/commando.7 \
- doc/commando-listrunes.7 \
- doc/commando-rune.7 \
- Cleaning up the RPC examples test file:
diff --git a/tests/autogenerate-rpc-examples.py b/tests/autogenerate-rpc-examples.py
-IGNORE_RPCS_LIST = ['dev-splice', 'reckless', 'sql-template',
- # Deprecated, pending complete removal
- 'commando-rune', 'commando-listrunes', 'commando-blacklist']
+IGNORE_RPCS_LIST = ['dev-splice', 'reckless', 'sql-template']
| @@ -469,43 +469,6 @@ def test_http_headers(node_factory): | |||
| assert response.headers['Access-Control-Allow-Origin'] == 'http://192.168.1.10:1010' | |||
|
|
|||
|
|
|||
| def test_old_params(node_factory): | |||
There was a problem hiding this comment.
Please remove the unused imports:
osfromtest_clnrest.pybase64fromtest_plugin.py
This is causing the pre-build step to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard cleanup for things which have been disabled for at least one version.