Skip to content

Spaces feature improvements#1240

Open
fbacall wants to merge 3 commits intomasterfrom
spaces-feature-toggle
Open

Spaces feature improvements#1240
fbacall wants to merge 3 commits intomasterfrom
spaces-feature-toggle

Conversation

@fbacall
Copy link
Member

@fbacall fbacall commented Feb 19, 2026

Summary of changes

  • Hide front page counters for features that are not enabled in the current space.
  • Allow hiding of the spaces index from the directory dropdown (still accessible from footer)

Motivation and context

Hiding empty/irrelevant content.

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the spaces feature by allowing fine-grained control over feature visibility within individual spaces. The changes enable space administrators to hide disabled features from the front page counters and optionally hide the spaces index from the navigation dropdown while keeping it accessible via the footer.

Changes:

  • Added 'spaces' to the list of features that can be disabled per-space
  • Updated counter display logic to respect space-specific feature flags
  • Added a "Browse Spaces" link to the footer for global spaces access

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/models/space.rb Added 'spaces' to FEATURES constant to enable per-space control
app/views/static/home/_counters.html.erb Changed feature filtering to use feature_enabled? helper, respecting both global and space-specific flags
app/views/layouts/_footer.html.erb Added "Browse Spaces" link to footer with global feature flag check
config/locales/en.yml Added browse_spaces translation key for the footer link
test/controllers/static_controller_test.rb Added tests for disabled feature counter hiding and spaces index visibility behavior
test/controllers/spaces_controller_test.rb Updated test count to reflect addition of 'spaces' to available features

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments