fix: add explicit compose network aliases for mysql and redis#1375
Open
Zhey-on wants to merge 1 commit intoEnAccess:mainfrom
Open
fix: add explicit compose network aliases for mysql and redis#1375Zhey-on wants to merge 1 commit intoEnAccess:mainfrom
Zhey-on wants to merge 1 commit intoEnAccess:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
This PR adds explicit Docker Compose default-network aliases for database/cache services to avoid DNS resolution failures in local and compose-based setups.
mysqlnow has aliases:db,mysqlredisnow has alias:redisUpdated files:
docker-compose.ymldocker-compose-prod.ymldocker-compose-dockerhub.ymlcloses: #1374
Are there any other side effects of this change that we should be aware of?
No functional side effects expected. This only makes service discovery explicit and more reliable.
Describe how you tested your changes?
Manual validation:
docker compose up -d --force-recreatedb,mysql, andredisnow resolve to container IPs.POST /api/auth/loginwithdemo_company_admin@example.com/123123http://localhost:8001.Pull Request checklist