Improve //hollow command#2960
Open
TomyLobo wants to merge 13 commits into
Open
Conversation
TomyLobo
force-pushed
the
improve-hollow
branch
6 times, most recently
from
7d72986 to
7c4af2d
Compare
Previously, the "Remove everything else in the selection" section had an extra recursion step to get from the "outside" blocks to the "visible" blocks.
Thickness 0 behaved like thickness 1
- Make a dedicated startingPositions Collection to initialize everything with - Move declarations closer to their usage
- Add -p flag to iterate from placement position instead of the selection boundaries - Add -g flag to consider geometry in visibility calculations - By default, //hollow will no longer open up faces that are touching the selection bounding box. The old behaviour can be access with the -o flag.
Previously, the algorithm could enter a top slab through the top side and leave through all other sides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old behaviour can be access with the -o flag.
Note: This shares 2 commits with #2952, please don't squash.