Open
Conversation
darefalola
requested changes
Jan 26, 2026
| else: | ||
| if len(release_version_result) > 1: | ||
| logger.warning(f"Multiple results returned. {release_version_result}") | ||
| response_data = msg_factory.create_label_version(release_version_result[0]) |
Contributor
There was a problem hiding this comment.
Is there any other check that can be used to return a specific release label when there are multiple labels returned. Is it possible to sort by date or any other field to get the most appropriate release label for the genome uuid?
| logger.warning("Missing or Empty Genome UUID field.") | ||
| return msg_factory.create_label_version() | ||
|
|
||
| release_version_result = db_conn.fetch_genome_datasets(genome_uuid=genome_uuid, |
Contributor
There was a problem hiding this comment.
Should the variable be release_label_result instead of release_verison_result? The function name and conversation says we are getting release labels. It might cause confusion for any other person that might want to refactor this later.
Check the variable names. I also see release_version being passed to the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Implement
GetReleaseLabelByUUIDgRPC callgenome_uuid: Mandatorydataset_type: OptionalExample
Query:
Response
Context
This will be used by Thoas instead of
GetReleaseVersionByUUIDto get where the genome is stored in Mongo DBNote
I will need to clean up the code once we stop using
GetReleaseVersionByUUID