-
Notifications
You must be signed in to change notification settings - Fork 2
fix: add global or import scripts into DOM #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sagardspeed2
wants to merge
9
commits into
main
Choose a base branch
from
1027-add-global-and-import-scripts-into-DOM
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0b54ba0
fix: add global or import scripts into DOM
sagardspeed2 903d022
fix: implemented basic scope
sagardspeed2 1fd32ef
wip: script scope and arguments
sagardspeed2 3482779
fix: added custom scope and evaluate it
sagardspeed2 4a7d9d0
fix: working on import scripts
sagardspeed2 cc73007
fix: added js in closures
sagardspeed2 387d335
fix: initialize ensemble before script mounting
sagardspeed2 68c03ad
fix: define ensemble before mounting
sagardspeed2 39974db
fix: improve context and window.ensemble update logic
sagardspeed2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| const productTitleName = "SgrDvr"; | ||
|
|
||
| const getDateLabel = (val) => { | ||
| return `i am a date label ${val}` | ||
| } | ||
| return `i am a date label ${val}`; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,6 +91,35 @@ export const EnsembleScreen: React.FC<EnsembleScreenProps> = ({ | |
| }; | ||
| }, [screen.customWidgets]); | ||
|
|
||
| useEffect(() => { | ||
| const globalBlock = screen.global; | ||
| const importedScripts = screen.importedScripts; | ||
|
|
||
| const isScriptExist = document.getElementById("custom-scope-script"); | ||
|
|
||
| const jsString = ` | ||
| ${importedScripts || ""} | ||
| ${globalBlock || ""} | ||
sagardspeed2 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| const myScreenScope = function(scriptToExecute, context) { | ||
| with (context) { | ||
| return eval('(' + scriptToExecute.toString() + ')()'); | ||
| } | ||
| } | ||
| `; | ||
|
|
||
| if (isScriptExist) { | ||
| isScriptExist.textContent = jsString; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This does not rerun the script, you need to remove the node and reinsert it. |
||
| } else { | ||
| const script = document.createElement("script"); | ||
| script.id = "custom-scope-script"; | ||
| script.type = "text/javascript"; | ||
| script.textContent = jsString; | ||
|
|
||
| document.body.appendChild(script); | ||
| } | ||
| }, [screen.global, screen.importedScripts]); | ||
|
|
||
| if (!isInitialized) { | ||
| return null; | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be unique per screen.