Skip to content

Conversation

@anserwaseem
Copy link
Collaborator

Describe your changes

Screenshots [Optional]

Issue ticket number and link

Closes #

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests
  • I have added a changeset pnpm changeset add
  • I have added example usage in the kitchen sink app

@anserwaseem anserwaseem requested a review from evshi June 26, 2025 16:39
@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2025

⚠️ No Changeset found

Latest commit: f6319b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@anserwaseem anserwaseem removed the request for review from evshi June 26, 2025 16:40
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025

Visit the preview URL for this PR (updated for commit f6319b5):

https://react-kitchen-sink-dev--pr1085-1027-nipbio4a.web.app

(expires Wed, 09 Jul 2025 12:35:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9

@anserwaseem anserwaseem marked this pull request as draft June 26, 2025 16:43
@anserwaseem anserwaseem marked this pull request as ready for review June 27, 2025 20:50
@anserwaseem anserwaseem requested a review from evshi June 27, 2025 20:50
@anserwaseem anserwaseem self-assigned this Jun 27, 2025
Copy link
Contributor

@evshi evshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you benchmark this/are there any improvements? This seems to cache each combined script but the issue is really that the shared scripts are still being parsed multiple times.

onTap:
executeCode: |
// Calls a function defined in test.js
debugger;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

@anserwaseem
Copy link
Collaborator Author

anserwaseem commented Jun 27, 2025

first loaded /maanger/tasks page
image

then loaded /workfflow page
image

@anserwaseem
Copy link
Collaborator Author

anserwaseem commented Jul 2, 2025

please refer two files each for before & after test results:
per-binding-test.zip

file explanation
first_load.js bindings result on first load of /manager/tasks page
set_page_size_100.js bindings result on setting page size to 100 on /manager/tasks page

Each entry in is an object that aggregates the timings recorded so far for that specific binding sorted by worst latency first:

entry explanation
count How many times that binding has been evaluated since the page was loaded.
total The sum (in ms) of all individual evaluation times.
avg Mean/average with total / count.
max The single slowest evaluation observed so far (worst-case latency).
min The single fastest evaluation observed so far (best-case latency).

@anserwaseem anserwaseem changed the title add the global and imported scripts to the document per screen cache global and imported scripts Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants