Added the draggable property to modals #793
Conversation
🦋 Changeset detectedLatest commit: 2b87085 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Visit the preview URL for this PR (updated for commit 2b87085): https://react-kitchen-sink-dev--pr793-740-implement-dragga-mvpuq0xf.web.app (expires Mon, 26 Aug 2024 20:45:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
| "dependencies": { | ||
| "react-draggable": "^4.4.6" |
There was a problem hiding this comment.
Please move to dev dependencies
| setBounds({ | ||
| left: -targetRect.left + uiData.x, | ||
| right: clientWidth - (targetRect.right - uiData.x), | ||
| top: -targetRect.top + uiData.y, | ||
| bottom: clientHeight - (targetRect.bottom - uiData.y), |
There was a problem hiding this comment.
What does this do? Would be nice to have a comment here.
| <Draggable | ||
| bounds={bounds} | ||
| disabled={false} | ||
| nodeRef={draggleRef} |
There was a problem hiding this comment.
What happens if you have multiple draggable modals?
2 participants
Describe your changes
Added a draggable property to modal screens allowing you to move modals around the screen
Screenshots [Optional]
Issue ticket number and link:
Issue #740
Closes #740
Checklist before requesting a review
pnpm changeset add